Page MenuHomePhabricator

Produce a more tailored checkout URI for Subversion
ClosedPublic

Authored by epriestley on Feb 28 2014, 8:54 PM.
Tags
None
Referenced Files
F13267221: D8375.diff
Wed, May 29, 3:02 AM
F13263464: D8375.id.diff
Mon, May 27, 9:37 AM
F13252678: D8375.diff
Sat, May 25, 1:57 AM
F13230380: D8375.diff
Mon, May 20, 10:55 PM
F13228954: D8375.id19905.diff
Mon, May 20, 1:34 PM
F13186238: D8375.diff
Sat, May 11, 3:30 AM
F13181518: D8375.id19904.diff
Thu, May 9, 12:52 PM
Unknown Object (File)
Apr 30 2024, 11:17 PM
Subscribers

Details

Summary

For imported SVN repositories with an "Import Only" path, we produce a /path/to/root/ URI, but should produce /path/to/root/then/to/import/only/.

As it is, the URI instructs the user to check out the whole repository.

Also, don't show the "Clone As" fragment in the URI for remote repositories, and prevent it from being edited for nonhosted repositories. This is generally more consistent with user expectation.

Test Plan
  • Created a remote SVN repository with "Import Only", saw path include it.
  • Verified no "Clone As" options, no "Clone As" in URI.
  • Switched it to hosted, saw "Clone As" options appear and work properly.

Diff Detail

Repository
rP Phabricator
Branch
svnimport
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2014, 9:04 PM
epriestley updated this revision to Unknown Object (????).Feb 28 2014, 9:04 PM
  • Add a unit test, since we have coverage on this stuff.