Page MenuHomePhabricator

Produce a more tailored checkout URI for Subversion
ClosedPublic

Authored by epriestley on Feb 28 2014, 8:54 PM.
Tags
None
Referenced Files
F13181518: D8375.id19904.diff
Thu, May 9, 12:52 PM
Unknown Object (File)
Tue, Apr 30, 11:17 PM
Unknown Object (File)
Sun, Apr 28, 5:30 AM
Unknown Object (File)
Sun, Apr 28, 5:30 AM
Unknown Object (File)
Sun, Apr 28, 5:30 AM
Unknown Object (File)
Sun, Apr 28, 5:30 AM
Unknown Object (File)
Sat, Apr 27, 11:10 AM
Unknown Object (File)
Mon, Apr 22, 10:35 PM
Subscribers

Details

Summary

For imported SVN repositories with an "Import Only" path, we produce a /path/to/root/ URI, but should produce /path/to/root/then/to/import/only/.

As it is, the URI instructs the user to check out the whole repository.

Also, don't show the "Clone As" fragment in the URI for remote repositories, and prevent it from being edited for nonhosted repositories. This is generally more consistent with user expectation.

Test Plan
  • Created a remote SVN repository with "Import Only", saw path include it.
  • Verified no "Clone As" options, no "Clone As" in URI.
  • Switched it to hosted, saw "Clone As" options appear and work properly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2014, 9:04 PM
epriestley updated this revision to Unknown Object (????).Feb 28 2014, 9:04 PM
  • Add a unit test, since we have coverage on this stuff.