Page MenuHomePhabricator

Produce a more tailored checkout URI for Subversion
ClosedPublic

Authored by epriestley on Feb 28 2014, 8:54 PM.
Tags
None
Referenced Files
F14054097: D8375.diff
Fri, Nov 15, 10:07 PM
F14043030: D8375.diff
Tue, Nov 12, 7:21 AM
F14027608: D8375.diff
Fri, Nov 8, 8:05 AM
F14013637: D8375.id19904.diff
Sat, Nov 2, 8:10 AM
F14003216: D8375.diff
Sat, Oct 26, 3:31 AM
F13994999: D8375.id19901.diff
Wed, Oct 23, 9:58 AM
F13975580: D8375.id19904.diff
Oct 18 2024, 10:47 AM
F13960177: D8375.id19901.diff
Oct 14 2024, 10:19 PM
Subscribers

Details

Summary

For imported SVN repositories with an "Import Only" path, we produce a /path/to/root/ URI, but should produce /path/to/root/then/to/import/only/.

As it is, the URI instructs the user to check out the whole repository.

Also, don't show the "Clone As" fragment in the URI for remote repositories, and prevent it from being edited for nonhosted repositories. This is generally more consistent with user expectation.

Test Plan
  • Created a remote SVN repository with "Import Only", saw path include it.
  • Verified no "Clone As" options, no "Clone As" in URI.
  • Switched it to hosted, saw "Clone As" options appear and work properly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2014, 9:04 PM
epriestley updated this revision to Unknown Object (????).Feb 28 2014, 9:04 PM
  • Add a unit test, since we have coverage on this stuff.