Page MenuHomePhabricator

Fix two issues with ref discovery
ClosedPublic

Authored by epriestley on Feb 28 2014, 8:14 PM.
Tags
None
Referenced Files
F14356323: D8373.id19902.diff
Thu, Dec 19, 8:30 PM
F14347865: D8373.id19902.diff
Thu, Dec 19, 3:48 AM
Unknown Object (File)
Tue, Dec 17, 11:13 AM
Unknown Object (File)
Sat, Dec 14, 10:46 AM
Unknown Object (File)
Thu, Dec 12, 11:19 PM
Unknown Object (File)
Thu, Dec 12, 7:17 PM
Unknown Object (File)
Sat, Dec 7, 9:31 PM
Unknown Object (File)
Tue, Dec 3, 1:12 PM

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPe28b78f5ebe3: Fix two issues with ref discovery
Summary

See IRC. I'm having trouble figuring out what's going on with b4taylor's report, but fix two possible issues:

  1. The commit query is missing a repositoryID, which could cause issues if you import two copies of the same repository.
  2. I think we may try to close commits on untracked branches right now, as long as they aren't excluded by other autoclose rules.
Test Plan

Ran bin/repository refs on a few repos.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2014, 8:55 PM

(This might be a fix for your issue.)

I think there's like a 10% chance this is actually a fix, but yell if it is.