Page MenuHomePhabricator

Fix two issues with ref discovery
ClosedPublic

Authored by epriestley on Feb 28 2014, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 12:19 AM
Unknown Object (File)
Mar 6 2026, 9:20 AM
Unknown Object (File)
Feb 28 2026, 11:20 PM
Unknown Object (File)
Feb 23 2026, 5:21 PM
Unknown Object (File)
Feb 7 2026, 4:51 AM
Unknown Object (File)
Dec 22 2025, 2:37 PM
Unknown Object (File)
Dec 21 2025, 7:17 PM
Unknown Object (File)
Nov 12 2025, 11:04 PM

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPe28b78f5ebe3: Fix two issues with ref discovery
Summary

See IRC. I'm having trouble figuring out what's going on with b4taylor's report, but fix two possible issues:

  1. The commit query is missing a repositoryID, which could cause issues if you import two copies of the same repository.
  2. I think we may try to close commits on untracked branches right now, as long as they aren't excluded by other autoclose rules.
Test Plan

Ran bin/repository refs on a few repos.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2014, 8:55 PM

(This might be a fix for your issue.)

I think there's like a 10% chance this is actually a fix, but yell if it is.