Page MenuHomePhabricator

Fix two issues with ref discovery
ClosedPublic

Authored by epriestley on Feb 28 2014, 8:14 PM.
Tags
None
Referenced Files
F13224764: D8373.id19902.diff
Sun, May 19, 10:44 AM
F13207584: D8373.id19902.diff
Thu, May 16, 1:06 AM
F13207583: D8373.id19899.diff
Thu, May 16, 1:06 AM
F13207513: D8373.id.diff
Thu, May 16, 12:42 AM
F13207481: D8373.diff
Thu, May 16, 12:20 AM
Unknown Object (File)
Sat, May 4, 6:23 PM
Unknown Object (File)
Tue, Apr 30, 11:16 PM
Unknown Object (File)
Sun, Apr 28, 5:29 AM

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPe28b78f5ebe3: Fix two issues with ref discovery
Summary

See IRC. I'm having trouble figuring out what's going on with b4taylor's report, but fix two possible issues:

  1. The commit query is missing a repositoryID, which could cause issues if you import two copies of the same repository.
  2. I think we may try to close commits on untracked branches right now, as long as they aren't excluded by other autoclose rules.
Test Plan

Ran bin/repository refs on a few repos.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2014, 8:55 PM

(This might be a fix for your issue.)

I think there's like a 10% chance this is actually a fix, but yell if it is.