Truncate Conduit 'clientDescription' so we don't overflow the column
ClosedPublic
Actions

Authored by epriestley on Feb 24 2014, 11:31 PM.

Tags

None

Referenced Files

	F13748442: D8327.diff
	Wed, Sep 4, 8:15 AM

	Unknown Object (File)
	Mon, Aug 26, 7:10 AM

	Unknown Object (File)
	Sun, Aug 25, 4:44 PM

	Unknown Object (File)
	Thu, Aug 22, 11:58 AM

	Unknown Object (File)
	Sun, Aug 11, 7:42 AM

	Unknown Object (File)
	Sun, Aug 11, 1:34 AM

	Unknown Object (File)
	Wed, Aug 7, 8:38 AM

	Unknown Object (File)
	Mon, Aug 5, 12:57 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP72a062d8027b: Truncate Conduit 'clientDescription' so we don't overflow the column

Summary

We store the arc commandline in this 255-character column, but it can be more than 255-characters long. If it's huge, truncate it.

Test Plan

Executed:

arc list --conduit-uri=http://local.aphront.com:8080/ --conduit-version 6.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

Works fine after this patch.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 25 2014, 4:54 PM

Closed by commit rP72a062d8027b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPI_conduit_connect_Method.php

3 lines

Diff 19826

View Options

src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php

Truncate Conduit 'clientDescription' so we don't overflow the columnClosedPublicActions