Truncate Conduit 'clientDescription' so we don't overflow the column
ClosedPublic
Actions

Authored by epriestley on Feb 24 2014, 11:31 PM.

Tags

None

Referenced Files

	F14843324: D8327.id19826.diff
	Sun, Feb 2, 5:40 AM

	F14842855: D8327.id19802.diff
	Sun, Feb 2, 2:25 AM

	Unknown Object (File)
	Thu, Jan 30, 3:46 AM

	Unknown Object (File)
	Tue, Jan 28, 4:32 AM

	Unknown Object (File)
	Fri, Jan 17, 7:44 AM

	Unknown Object (File)
	Fri, Jan 17, 2:21 AM

	Unknown Object (File)
	Wed, Jan 8, 2:44 PM

	Unknown Object (File)
	Dec 17 2024, 11:14 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP72a062d8027b: Truncate Conduit 'clientDescription' so we don't overflow the column

Summary

We store the arc commandline in this 255-character column, but it can be more than 255-characters long. If it's huge, truncate it.

Test Plan

Executed:

arc list --conduit-uri=http://local.aphront.com:8080/ --conduit-version 6.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

Works fine after this patch.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 25 2014, 4:54 PM

Closed by commit rP72a062d8027b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPI_conduit_connect_Method.php

3 lines

Diff 19826

View Options

src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php

Truncate Conduit 'clientDescription' so we don't overflow the columnClosedPublicActions