Fix variable issue on Conpherence draft saving pathway
ClosedPublic
Actions

Authored by epriestley on Feb 24 2014, 7:48 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP5f95f2b6d51e: Fix variable issue on Conpherence draft saving pathway

Summary

When we save a Conpherence draft, the draft part works fine but $xactions never gets defined, so this gets hit a little later on:

[24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message: [2014-02-24 11:46:10] EXCEPTION: (RuntimeException) Undefined variable: xactions at [/INSECURE/devtools/libphutil/src/error/PhutilErrorHandler.php:211]"
[24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message:   #0 PhutilErrorHandler::handleError(8, Undefined variable: xactions, /INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php, 122, Array of size 13 starting with: { request => Object AphrontRequest }) called at [/INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php:122]"
[24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message:   #1 ConpherenceUpdateController::processRequest() called at [/INSECURE/devtools/phabricator/webroot/index.php:87]"

Instead, define $xactions.

Test Plan

Type into Conpherence while tailing the error log.
After patch, clean error log.

Diff Detail

Repository

rP Phabricator

Branch

conpherence

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Thank you sir. Apologies for putting poop in your error log.

haha, no problem. I think we intentionally ignore errors in ShapedRequest, which is most of the root cause here. A more systematic fix might be to ignore errors only in production, but as long as we're only hitting this kind of thing a couple times a year I'm inclined not to bother.

Closed by commit rP5f95f2b6d51e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

4 lines

Diff 19794

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Fix variable issue on Conpherence draft saving pathwayClosedPublicActions