Page MenuHomePhabricator
Differential D8323

Fix variable issue on Conpherence draft saving pathway
ClosedPublic
Actions

Authored by epriestley on Feb 24 2014, 7:48 PM.
Tags
None
Referenced Files
F13894279: D8323.diff
Sat, Oct 5, 12:19 PM
Unknown Object (File)
Mon, Sep 23, 1:12 PM
Unknown Object (File)
Mon, Sep 23, 1:12 PM
Unknown Object (File)
Mon, Sep 23, 1:12 PM
Unknown Object (File)
Mon, Sep 23, 1:09 PM
Unknown Object (File)
Fri, Sep 13, 11:31 PM
Unknown Object (File)
Wed, Sep 11, 6:16 PM
Unknown Object (File)
Sep 4 2024, 10:20 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP5f95f2b6d51e: Fix variable issue on Conpherence draft saving pathway
Summary

When we save a Conpherence draft, the draft part works fine but $xactions never gets defined, so this gets hit a little later on:

[24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message: [2014-02-24 11:46:10] EXCEPTION: (RuntimeException) Undefined variable: xactions at [/INSECURE/devtools/libphutil/src/error/PhutilErrorHandler.php:211]"
[24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message:   #0 PhutilErrorHandler::handleError(8, Undefined variable: xactions, /INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php, 122, Array of size 13 starting with: { request => Object AphrontRequest }) called at [/INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php:122]"
[24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message:   #1 ConpherenceUpdateController::processRequest() called at [/INSECURE/devtools/phabricator/webroot/index.php:87]"

Instead, define $xactions.

Test Plan
  • Type into Conpherence while tailing the error log.
  • After patch, clean error log.

Diff Detail

Repository
rP Phabricator
Branch
conpherence
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Feb 24 2014, 7:53 PM

Thank you sir. Apologies for putting poop in your error log.

epriestley added a comment.Feb 24 2014, 7:55 PM

haha, no problem. I think we intentionally ignore errors in ShapedRequest, which is most of the root cause here. A more systematic fix might be to ignore errors only in production, but as long as we're only hitting this kind of thing a couple times a year I'm inclined not to bother.

epriestley closed this revision.Feb 24 2014, 7:56 PM

Closed by commit rP5f95f2b6d51e (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
4 lines

Diff 19794

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
Phabricator · Built by Phacility