Paths

Table of Contentst

Fix phutil_is_utf8_with_only_bmp_characters() for partial valid characters
ClosedPublic
Actions

Authored by epriestley on Feb 24 2014, 7:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 10:21 AM

	Unknown Object (File)
	Sun, Apr 28, 5:20 AM

	Unknown Object (File)
	Sun, Apr 28, 5:20 AM

	Unknown Object (File)
	Thu, Apr 25, 3:19 AM

	Unknown Object (File)
	Mon, Apr 15, 12:27 AM

	Unknown Object (File)
	Thu, Apr 11, 8:51 AM

	Unknown Object (File)
	Thu, Apr 11, 8:51 AM

	Unknown Object (File)
	Thu, Apr 11, 5:43 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

rPHUa1c59161e70b: Fix phutil_is_utf8_with_only_bmp_characters() for partial valid characters

Summary

We don't get partial 2-byte and 3-byte UTF8 characters quite correct, fataling instead of returning false because we access past the end of the string.

Instead, bail early if we run off the end of the string without seeing any issues.

Test Plan

Added and executed unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 24 2014, 7:28 PM

Closed by commit rPHUa1c59161e70b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUTF8TestCase.php

5 lines

utf8.php

30 lines

Diff 19793

View Options

src/utils/tests/PhutilUTF8TestCase.php

View Options

Fix phutil_is_utf8_with_only_bmp_characters() for partial valid charactersClosedPublicActions