Page MenuHomePhabricator

Change "%s" in qsprintf to exclude non-BMP characters
ClosedPublic

Authored by epriestley on Feb 23 2014, 9:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 10:39 AM
Unknown Object (File)
Sun, Feb 9, 11:37 AM
Unknown Object (File)
Sun, Feb 9, 11:37 AM
Unknown Object (File)
Sun, Feb 9, 11:37 AM
Unknown Object (File)
Thu, Feb 6, 12:09 AM
Unknown Object (File)
Tue, Jan 28, 11:09 PM
Unknown Object (File)
Tue, Jan 28, 6:22 AM
Unknown Object (File)
Sat, Jan 25, 5:19 PM
Subscribers

Details

Summary

Ref T1191. Make %s in qsprintf reject non-BMP characters. Introduce %B for escaping binary strings.

Basically, this just makes "yes, I want to put binary data in this column" explicit.

Test Plan

See next diff for test coverage in Phabricator.

Diff Detail

Repository
rPHU libphutil
Branch
bmp4
Lint
Lint Passed
Unit
Tests Passed