Paths

Table of Contentst

Change "%s" in qsprintf to exclude non-BMP characters
ClosedPublic
Actions

Authored by epriestley on Feb 23 2014, 9:29 PM.

Details

Reviewers

arice
btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

rPHU5a9002ebed4f: Change "%s" in qsprintf to exclude non-BMP characters

Summary

Ref T1191. Make %s in qsprintf reject non-BMP characters. Introduce %B for escaping binary strings.

Basically, this just makes "yes, I want to put binary data in this column" explicit.

Test Plan

See next diff for test coverage in Phabricator.

Diff Detail

Repository

rPHU libphutil

Branch

bmp4

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

arice accepted this revision.Feb 23 2014, 11:40 PM

Closed by commit rPHU5a9002ebed4f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

aphront/

storage/

connection/

AphrontIsolatedDatabaseConnection.php

6 lines

mysql/

AphrontMySQLDatabaseConnection.php

7 lines

AphrontMySQLDatabaseConnectionBase.php

20 lines

AphrontMySQLiDatabaseConnection.php

7 lines

exception/

AphrontQueryCharacterSetException.php

5 lines

xsprintf/

PhutilQsprintfInterface.php

3 lines

qsprintf.php

45 lines

Diff 19767

View Options

src/__phutil_library_map__.php

View Options

src/aphront/storage/connection/AphrontIsolatedDatabaseConnection.php

View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php

View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

View Options

src/aphront/storage/exception/AphrontQueryCharacterSetException.php

View Options

src/xsprintf/PhutilQsprintfInterface.php

View Options

Change "%s" in qsprintf to exclude non-BMP charactersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19767

src/__phutil_library_map__.php

src/aphront/storage/connection/AphrontIsolatedDatabaseConnection.php

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

src/aphront/storage/exception/AphrontQueryCharacterSetException.php

src/xsprintf/PhutilQsprintfInterface.php

src/xsprintf/qsprintf.php

Change "%s" in qsprintf to exclude non-BMP characters
ClosedPublic
Actions

Revision Contents
Changeset List