Page MenuHomePhabricator

Add test coverage that our definition of BMP agrees with MySQL
ClosedPublic

Authored by epriestley on Feb 23 2014, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 1:50 PM
Unknown Object (File)
Sat, Mar 16, 4:44 AM
Unknown Object (File)
Tue, Mar 5, 7:56 AM
Unknown Object (File)
Feb 21 2024, 5:42 AM
Unknown Object (File)
Feb 15 2024, 3:52 PM
Unknown Object (File)
Jan 21 2024, 3:21 PM
Unknown Object (File)
Jan 16 2024, 12:39 AM
Unknown Object (File)
Jan 16 2024, 12:39 AM
Subscribers

Details

Summary

Ref T1191. Test that MySQL's rules match those of phutil_is_utf8_with_only_bmp_characters():

  • Build a string with every character that we consider to be a BMP character.
  • Write it into MySQL.
  • Read it back out.
  • Make sure MySQL didn't truncate it.
Test Plan

Ran unit test. This test runs pretty quickly (50ms), the string with every character isn't all that enormous.

Diff Detail

Repository
rP Phabricator
Branch
pmbp1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 23 2014, 8:40 PM
  • Adjust the character ranges to match phutil_is_utf8_with_only_bmp_characters().