Move "Open in Editor" to File Box
ClosedPublic
Actions

Authored by chad on Feb 21 2014, 10:39 PM.

Tags

None

Referenced Files

	F15513788: D8300.id19743.diff
	Thu, Apr 17, 9:53 PM

	F15494488: D8300.diff
	Sun, Apr 13, 12:09 AM

	F15468014: D8300.diff
	Thu, Apr 3, 7:22 PM

	F15461033: D8300.id.diff
	Tue, Apr 1, 4:33 AM

	F15458829: D8300.id19744.diff
	Mon, Mar 31, 7:47 AM

	F15379116: D8300.id19743.diff
	Mar 13 2025, 6:47 PM

	Unknown Object (File)
	Mar 1 2025, 2:39 PM

	Unknown Object (File)
	Feb 25 2025, 12:22 PM

Subscribers

Details

Reviewers

epriestley

Maniphest Tasks

T4467: Minimize actionlist in Diffusion Browse View

Commits

Restricted Diffusion Commit
rPce5eafe7f19b: Move "Open in Editor" to File Box

Summary

Moves this single action to the File Contents box in Diffusion Browse. Also fixes a PHUIObjectBox missing when enable highlighting is on.

Test Plan

Enable/Disable Highlighting. See disabled Editor button.

Diff Detail

Repository

rP Phabricator

Branch

diffusion-highlight

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley accepted this revision.Feb 21 2014, 10:42 PM

Closed by commit rPce5eafe7f19b (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

39 lines

view/

phui/

PHUIButtonView.php

10 lines

Diff 19743

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php