Move "Open in Editor" to File Box
ClosedPublic
Actions

Authored by chad on Feb 21 2014, 10:39 PM.

Tags

None

Referenced Files

	F14117807: D8300.id19744.diff
	Thu, Nov 28, 8:42 PM

	F14117806: D8300.id.diff
	Thu, Nov 28, 8:42 PM

	F14117805: D8300.id19743.diff
	Thu, Nov 28, 8:42 PM

	F14116567: D8300.diff
	Thu, Nov 28, 4:02 PM

	Unknown Object (File)
	Wed, Nov 27, 8:02 AM

	Unknown Object (File)
	Tue, Nov 26, 4:20 PM

	Unknown Object (File)
	Sun, Nov 24, 12:52 PM

	Unknown Object (File)
	Thu, Nov 21, 9:40 AM

Subscribers

Details

Reviewers

epriestley

Maniphest Tasks

T4467: Minimize actionlist in Diffusion Browse View

Commits

Restricted Diffusion Commit
rPce5eafe7f19b: Move "Open in Editor" to File Box

Summary

Moves this single action to the File Contents box in Diffusion Browse. Also fixes a PHUIObjectBox missing when enable highlighting is on.

Test Plan

Enable/Disable Highlighting. See disabled Editor button.

Diff Detail

Repository

rP Phabricator

Branch

diffusion-highlight

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley accepted this revision.Feb 21 2014, 10:42 PM

Closed by commit rPce5eafe7f19b (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

39 lines

view/

phui/

PHUIButtonView.php

10 lines

Diff 19743

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php