...cuz it won't work. I think adding a "login to upload" has no real value as this is a pretty unexpected / power user feature anyway. Fixes T4354.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4354: File uploads for logged-out users are confusing
- Commits
- Restricted Diffusion Commit
rP2a277bbc038c: Hide upload JS stuff if user isn't logged in
tried to upload as a logged out user to Phabricator home. my browser just loaded the file as expected.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T4354
- Lint
Lint Errors Severity Location Code Message Error src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41 PHL1 Unknown Symbol Error src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49 PHL1 Unknown Symbol Error src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53 PHL1 Unknown Symbol - Unit
No Test Coverage
Event Timeline
Comment Actions
(AphrontView already has setUser(), which you could reuse. It might be nice to rename that to setViewer() some day but it would be a lot of work.)
I think adding a "login to upload" has no real value as this is a pretty unexpected / power user feature anyway.
Yep, agreed.
Comment Actions
I think it's:
- Update arcanist/ if you haven't;
- nuke src/.phutil_module_cache from phabricator/.