Page MenuHomePhabricator

Herald - add application search for transcripts
ClosedPublic

Authored by btrahan on Feb 21 2014, 8:22 PM.
Tags
None
Referenced Files
F15736637: D8297.diff
Thu, May 29, 5:20 PM
Unknown Object (File)
Mon, May 26, 12:19 AM
Unknown Object (File)
Thu, May 8, 9:09 PM
Unknown Object (File)
Thu, May 8, 6:08 AM
Unknown Object (File)
Thu, May 8, 6:08 AM
Unknown Object (File)
Wed, May 7, 2:41 PM
Unknown Object (File)
Wed, May 7, 11:43 AM
Unknown Object (File)
Mon, May 5, 6:06 AM

Details

Summary

this diff also makes the "test console" appear with the main search nav *and* updates application search to use the page title as the crumb rather than just search. Fixes T4399.

Test Plan

queried for transcript ids - success! queried for TX and MX - success! saved the TX and MX query and it worked again!

Diff Detail

Repository
rP Phabricator
Branch
T4399
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53PHL1Unknown Symbol
Unit
No Test Coverage

Event Timeline

Awesome!

src/applications/herald/controller/HeraldTranscriptListController.php
101

Consider overriding buildApplicationCrumbs() here to add a "Transcripts" crumb, similar to the "Build Plans" crumb here:

https://secure.phabricator.com/harbormaster/plan/

btrahan updated this revision to Unknown Object (????).Feb 21 2014, 8:50 PM

override crumbs for better UI experience