this diff also makes the "test console" appear with the main search nav *and* updates application search to use the page title as the crumb rather than just search. Fixes T4399.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4399: Implement ApplicationSearch for Herald transcripts
- Commits
- Restricted Diffusion Commit
rP20a3ee24f9e2: Herald - add application search for transcripts
queried for transcript ids - success! queried for TX and MX - success! saved the TX and MX query and it worked again!
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T4399
- Lint
Lint Errors Severity Location Code Message Error src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41 PHL1 Unknown Symbol Error src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49 PHL1 Unknown Symbol Error src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53 PHL1 Unknown Symbol - Unit
No Test Coverage
Event Timeline
Comment Actions
Awesome!
src/applications/herald/controller/HeraldTranscriptListController.php | ||
---|---|---|
101 | Consider overriding buildApplicationCrumbs() here to add a "Transcripts" crumb, similar to the "Build Plans" crumb here: |