Page MenuHomePhabricator

Herald - add application search for transcripts
ClosedPublic

Authored by btrahan on Feb 21 2014, 8:22 PM.
Tags
None
Referenced Files
F15462983: D8297.id19737.diff
Tue, Apr 1, 7:30 PM
F15437081: D8297.id19735.diff
Tue, Mar 25, 5:26 PM
F15427888: D8297.diff
Sun, Mar 23, 4:41 PM
F15414577: D8297.id19735.diff
Thu, Mar 20, 1:16 AM
F15414565: D8297.id19738.diff
Thu, Mar 20, 1:13 AM
F15412657: D8297.id.diff
Wed, Mar 19, 2:12 PM
F15384171: D8297.id19737.diff
Fri, Mar 14, 7:01 PM
F15384006: D8297.id19738.diff
Fri, Mar 14, 6:32 PM

Details

Summary

this diff also makes the "test console" appear with the main search nav *and* updates application search to use the page title as the crumb rather than just search. Fixes T4399.

Test Plan

queried for transcript ids - success! queried for TX and MX - success! saved the TX and MX query and it worked again!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Awesome!

src/applications/herald/controller/HeraldTranscriptListController.php
110–111

Consider overriding buildApplicationCrumbs() here to add a "Transcripts" crumb, similar to the "Build Plans" crumb here:

https://secure.phabricator.com/harbormaster/plan/

btrahan updated this revision to Unknown Object (????).Feb 21 2014, 8:50 PM

override crumbs for better UI experience