Page MenuHomePhabricator

Herald - add application search for transcripts
ClosedPublic

Authored by btrahan on Feb 21 2014, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 10:22 PM
Unknown Object (File)
Tue, Dec 10, 4:28 AM
Unknown Object (File)
Tue, Dec 10, 2:44 AM
Unknown Object (File)
Mon, Dec 9, 5:52 PM
Unknown Object (File)
Fri, Nov 29, 1:54 AM
Unknown Object (File)
Fri, Nov 29, 1:54 AM
Unknown Object (File)
Tue, Nov 26, 4:20 PM
Unknown Object (File)
Nov 19 2024, 8:09 AM

Details

Summary

this diff also makes the "test console" appear with the main search nav *and* updates application search to use the page title as the crumb rather than just search. Fixes T4399.

Test Plan

queried for transcript ids - success! queried for TX and MX - success! saved the TX and MX query and it worked again!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Awesome!

src/applications/herald/controller/HeraldTranscriptListController.php
110–111

Consider overriding buildApplicationCrumbs() here to add a "Transcripts" crumb, similar to the "Build Plans" crumb here:

https://secure.phabricator.com/harbormaster/plan/

btrahan updated this revision to Unknown Object (????).Feb 21 2014, 8:50 PM

override crumbs for better UI experience