Page MenuHomePhabricator

Implement Differential subscribers as a CustomField
ClosedPublic

Authored by epriestley on Feb 21 2014, 1:44 AM.
Tags
None
Referenced Files
F18776701: D8289.diff
Fri, Oct 10, 11:01 PM
F18619221: D8289.id19716.diff
Sep 15 2025, 2:00 AM
F18598991: D8289.diff
Sep 13 2025, 6:22 AM
F18597270: D8289.id.diff
Sep 13 2025, 2:29 AM
F18595596: D8289.diff
Sep 12 2025, 10:14 PM
F18579529: D8289.id19729.diff
Sep 11 2025, 1:15 AM
F18578505: D8289.id.diff
Sep 10 2025, 10:24 PM
F18578127: D8289.id19716.diff
Sep 10 2025, 9:12 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPaa7ba4c6e6d6: Implement Differential subscribers as a CustomField
Summary

Ref T3886. Now that a custom field can emit a core transaction, just emit a subscribers transaction.

Test Plan

{F116014}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/customfield/DifferentialCoreCustomField.php
17–22

Subclasses of CoreField only need to implement this if they're using a TYPE_CUSTOMFIELD transaction. Otherwise we'll do the write as part of the SUBSCRIBERS or EDGE or VIEW_POLICY or whatever else transaction.

src/applications/differential/customfield/DifferentialRepositoryField.php
32

(Small derp on my part.)