Page MenuHomePhabricator

Implement Differential subscribers as a CustomField
ClosedPublic

Authored by epriestley on Feb 21 2014, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 9:56 PM
Unknown Object (File)
Nov 2 2024, 1:26 AM
Unknown Object (File)
Nov 2 2024, 1:26 AM
Unknown Object (File)
Nov 2 2024, 1:26 AM
Unknown Object (File)
Oct 31 2024, 10:17 PM
Unknown Object (File)
Oct 25 2024, 12:15 PM
Unknown Object (File)
Oct 25 2024, 2:04 AM
Unknown Object (File)
Oct 24 2024, 11:55 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPaa7ba4c6e6d6: Implement Differential subscribers as a CustomField
Summary

Ref T3886. Now that a custom field can emit a core transaction, just emit a subscribers transaction.

Test Plan

{F116014}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/customfield/DifferentialCoreCustomField.php
17–22

Subclasses of CoreField only need to implement this if they're using a TYPE_CUSTOMFIELD transaction. Otherwise we'll do the write as part of the SUBSCRIBERS or EDGE or VIEW_POLICY or whatever else transaction.

src/applications/differential/customfield/DifferentialRepositoryField.php
32

(Small derp on my part.)