Page MenuHomePhabricator

Allow CustomField to provide ApplicationTransaction change details
ClosedPublic

Authored by epriestley on Feb 20 2014, 6:41 PM.
Tags
None
Referenced Files
F13098037: D8284.id19708.diff
Fri, Apr 26, 3:44 AM
Unknown Object (File)
Thu, Apr 25, 3:05 AM
Unknown Object (File)
Sat, Apr 20, 6:28 PM
Unknown Object (File)
Wed, Apr 17, 2:09 AM
Unknown Object (File)
Sat, Apr 6, 11:14 PM
Unknown Object (File)
Sat, Apr 6, 1:17 AM
Unknown Object (File)
Thu, Apr 4, 7:31 PM
Unknown Object (File)
Thu, Apr 4, 11:17 AM
Subscribers

Details

Summary

Ref T3886. Ref T418. For fields like "Summary" and "Test Plan" where changes can't be summarized in one line, allow CustomField to provide a "(Show Details)" link and render a diff.

Also consolidate some of the existing copy/paste, and simplify this featuer slightly now that we've move to dialogs.

Test Plan

{F115918}

  • Viewed "description"-style field changes in phlux, pholio, legalpad, maniphest, differential, ponder (questions), ponder (answers), and repositories.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Dialog seems like a better UI to me. Curious to see if we get any reactions.