Page MenuHomePhabricator

Allow CustomField to provide ApplicationTransaction change details
ClosedPublic

Authored by epriestley on Feb 20 2014, 6:41 PM.
Tags
None
Referenced Files
F18842528: D8284.diff
Tue, Oct 28, 4:17 PM
F18830622: D8284.diff
Sat, Oct 25, 7:43 AM
F18770820: D8284.id19708.diff
Wed, Oct 8, 3:14 PM
F18759948: D8284.id.diff
Mon, Oct 6, 7:02 AM
F18757330: D8284.diff
Sun, Oct 5, 4:55 PM
F18673715: D8284.id19725.diff
Sep 25 2025, 11:44 AM
F18673476: D8284.diff
Sep 25 2025, 10:47 AM
F18557217: D8284.id.diff
Sep 8 2025, 7:53 PM
Subscribers

Details

Summary

Ref T3886. Ref T418. For fields like "Summary" and "Test Plan" where changes can't be summarized in one line, allow CustomField to provide a "(Show Details)" link and render a diff.

Also consolidate some of the existing copy/paste, and simplify this featuer slightly now that we've move to dialogs.

Test Plan

{F115918}

  • Viewed "description"-style field changes in phlux, pholio, legalpad, maniphest, differential, ponder (questions), ponder (answers), and repositories.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Dialog seems like a better UI to me. Curious to see if we get any reactions.