Page MenuHomePhabricator
Differential D8282

Don't prompt to upgrade unset passwords
ClosedPublic
Actions

Authored by epriestley on Feb 20 2014, 3:36 PM.
Tags
None
Referenced Files
F16412403: D8282.diff
Mon, Jun 16, 5:57 AM
Unknown Object (File)
Mon, Jun 9, 1:57 AM
Unknown Object (File)
May 6 2025, 9:10 AM
Unknown Object (File)
Apr 30 2025, 4:26 AM
Unknown Object (File)
Apr 28 2025, 3:49 PM
Unknown Object (File)
Apr 28 2025, 11:19 AM
Unknown Object (File)
Apr 27 2025, 7:25 AM
Unknown Object (File)
Apr 26 2025, 7:38 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4463: Password Reset doesn't work
Commits
Restricted Diffusion Commit
rP55a94d8aba2a: Don't prompt to upgrade unset passwords
Summary

Fixes T4463. When your VCS or account password is not set, we test it for upgrade anyway. This doesn't make sense and throws shortly into the process because the empty hash isn't parseable.

Instead, only show upgrade prompts when the password exists.

Test Plan
  • Added a password to an existing account with no password via password reset.
  • Added a VCS password to an existing account with no VCS password.
  • Observed no fatals / nonsense behaviors.

Diff Detail

Repository
rP Phabricator
Branch
emptypass
Lint
Lint Passed
Unit
Tests Passed

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
panel/
12 lines
settings/
panel/
12 lines
infrastructure/
util/
password/
5 lines

Diff 19705

View Options

src/applications/diffusion/panel/DiffusionSetPasswordPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelPassword.php

Loading...
View Options

src/infrastructure/util/password/PhabricatorPasswordHasher.php

Loading...
Phabricator · Built by Phacility