Page MenuHomePhabricator

Don't prompt to upgrade unset passwords
ClosedPublic

Authored by epriestley on Feb 20 2014, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 10:56 PM
Unknown Object (File)
Fri, Oct 25, 11:45 AM
Unknown Object (File)
Thu, Oct 24, 11:53 AM
Unknown Object (File)
Oct 22 2024, 4:12 PM
Unknown Object (File)
Oct 7 2024, 8:33 PM
Unknown Object (File)
Oct 6 2024, 4:55 PM
Unknown Object (File)
Sep 6 2024, 7:24 PM
Unknown Object (File)
Sep 5 2024, 10:38 PM
Subscribers

Details

Summary

Fixes T4463. When your VCS or account password is not set, we test it for upgrade anyway. This doesn't make sense and throws shortly into the process because the empty hash isn't parseable.

Instead, only show upgrade prompts when the password exists.

Test Plan
  • Added a password to an existing account with no password via password reset.
  • Added a VCS password to an existing account with no VCS password.
  • Observed no fatals / nonsense behaviors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped