Page MenuHomePhabricator

Don't prompt to upgrade unset passwords
ClosedPublic

Authored by epriestley on Feb 20 2014, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 9:39 PM
Unknown Object (File)
Sun, Dec 15, 12:50 PM
Unknown Object (File)
Sun, Dec 15, 6:01 AM
Unknown Object (File)
Nov 27 2024, 4:15 PM
Unknown Object (File)
Nov 27 2024, 6:49 AM
Unknown Object (File)
Nov 23 2024, 4:14 AM
Unknown Object (File)
Nov 18 2024, 10:56 PM
Unknown Object (File)
Oct 25 2024, 11:45 AM
Subscribers

Details

Summary

Fixes T4463. When your VCS or account password is not set, we test it for upgrade anyway. This doesn't make sense and throws shortly into the process because the empty hash isn't parseable.

Instead, only show upgrade prompts when the password exists.

Test Plan
  • Added a password to an existing account with no password via password reset.
  • Added a VCS password to an existing account with no VCS password.
  • Observed no fatals / nonsense behaviors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped