Page MenuHomePhabricator

Don't prompt to upgrade unset passwords
ClosedPublic

Authored by epriestley on Feb 20 2014, 3:36 PM.
Tags
None
Referenced Files
F18837631: D8282.id.diff
Mon, Oct 27, 7:00 AM
F18834325: D8282.diff
Sun, Oct 26, 7:56 AM
F18628601: D8282.id19705.diff
Sep 16 2025, 6:41 AM
F18628590: D8282.id19706.diff
Sep 16 2025, 6:40 AM
F18599068: D8282.id.diff
Sep 13 2025, 6:34 AM
F18595169: D8282.diff
Sep 12 2025, 8:39 PM
F18590887: D8282.diff
Sep 12 2025, 7:34 AM
F18557208: D8282.id.diff
Sep 8 2025, 7:53 PM
Subscribers

Details

Summary

Fixes T4463. When your VCS or account password is not set, we test it for upgrade anyway. This doesn't make sense and throws shortly into the process because the empty hash isn't parseable.

Instead, only show upgrade prompts when the password exists.

Test Plan
  • Added a password to an existing account with no password via password reset.
  • Added a VCS password to an existing account with no VCS password.
  • Observed no fatals / nonsense behaviors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped