Page MenuHomePhabricator

Implement "Pro" version of revision editor, with one field
ClosedPublic

Authored by epriestley on Feb 19 2014, 12:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 9:52 PM
Unknown Object (File)
Wed, Jan 29, 7:45 AM
Unknown Object (File)
Thu, Jan 23, 9:50 PM
Unknown Object (File)
Thu, Jan 23, 9:50 PM
Unknown Object (File)
Thu, Jan 23, 9:50 PM
Unknown Object (File)
Thu, Jan 23, 9:36 PM
Unknown Object (File)
Fri, Jan 17, 3:51 PM
Unknown Object (File)
Thu, Jan 9, 2:29 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP65bc2b1ac53d: Implement "Pro" version of revision editor, with one field
Summary

Ref T3886. I spent a few hours trying to make DifferentialFieldSpecification extend PhabricatorCustomField so I could be more blunt in my approach here and just swap the whole thing over in one go (more or less like I did with Maniphest) but we have a ton of custom fields and things felt really shaky and the change was enormous and hard to keep track of.

Instead, I'm going to do this more gradually and go field-by-field. This implements a CustomField version of the "Title" field.

(There are no links to this in the UI.)

Test Plan

{F115353}

{F115354}

Diff Detail

Repository
rP Phabricator
Branch
dfield2
Lint
Lint Passed
Unit
Tests Passed