Page MenuHomePhabricator

Implement "Pro" version of revision editor, with one field
ClosedPublic

Authored by epriestley on Feb 19 2014, 12:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 4:37 PM
Unknown Object (File)
Apr 26 2025, 10:52 AM
Unknown Object (File)
Apr 25 2025, 7:18 AM
Unknown Object (File)
Apr 7 2025, 11:37 PM
Unknown Object (File)
Mar 30 2025, 9:53 PM
Unknown Object (File)
Mar 30 2025, 6:51 PM
Unknown Object (File)
Mar 29 2025, 4:38 AM
Unknown Object (File)
Mar 28 2025, 9:45 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP65bc2b1ac53d: Implement "Pro" version of revision editor, with one field
Summary

Ref T3886. I spent a few hours trying to make DifferentialFieldSpecification extend PhabricatorCustomField so I could be more blunt in my approach here and just swap the whole thing over in one go (more or less like I did with Maniphest) but we have a ton of custom fields and things felt really shaky and the change was enormous and hard to keep track of.

Instead, I'm going to do this more gradually and go field-by-field. This implements a CustomField version of the "Title" field.

(There are no links to this in the UI.)

Test Plan

{F115353}

{F115354}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped