Differential D8262

Bring "Reverts X" to more general infrastructure and port unit tests
ClosedPublic
Actions

Authored by epriestley on Feb 17 2014, 7:35 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP5afddb6703c8: Bring "Reverts X" to more general infrastructure and port unit tests

Summary

Ref T3886. See D8261. This brings the "reverts x" phrase to modern infrastructure. It isn't actually called by the real parser yet, I'm going to do that in one go at the end so I can test everything more easily.

This had unit tests; port most of them forward.

Test Plan

Added and executed unit tests.

Diff Detail

Repository

rP Phabricator

Branch

diff2

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Feb 17 2014, 10:20 PM

Closed by commit rP5afddb6703c8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

differential/

field/

parser/

DifferentialCustomFieldDependsOnParser.php

2 lines

DifferentialCustomFieldRevertsParser.php

51 lines

__tests__/

DifferentialCustomFieldDependsOnParserTestCase.php

6 lines

DifferentialCustomFieldRevertsParserTestCase.php

92 lines

specification/

__tests__/

DifferentialFreeformFieldTestCase.php

infrastructure/

customfield/

parser/

PhabricatorCustomFieldMonogramParser.php

4 lines

Diff 19650

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/field/parser/DifferentialCustomFieldDependsOnParser.php

View Options

src/applications/differential/field/parser/DifferentialCustomFieldRevertsParser.php

View Options

src/applications/differential/field/parser/tests/DifferentialCustomFieldDependsOnParserTestCase.php

View Options

src/applications/differential/field/parser/tests/DifferentialCustomFieldRevertsParserTestCase.php

View Options

src/applications/differential/field/specification/tests/DifferentialFreeformFieldTestCase.php

View Options

src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php

Bring "Reverts X" to more general infrastructure and port unit testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19650

src/__phutil_library_map__.php

src/applications/differential/field/parser/DifferentialCustomFieldDependsOnParser.php

src/applications/differential/field/parser/DifferentialCustomFieldRevertsParser.php

src/applications/differential/field/parser/__tests__/DifferentialCustomFieldDependsOnParserTestCase.php

src/applications/differential/field/parser/__tests__/DifferentialCustomFieldRevertsParserTestCase.php

src/applications/differential/field/specification/__tests__/DifferentialFreeformFieldTestCase.php

src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php

Bring "Reverts X" to more general infrastructure and port unit tests
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/differential/field/parser/tests/DifferentialCustomFieldDependsOnParserTestCase.php

src/applications/differential/field/parser/tests/DifferentialCustomFieldRevertsParserTestCase.php

src/applications/differential/field/specification/tests/DifferentialFreeformFieldTestCase.php