Break Aphlict's flash policy server into a separate class
ClosedPublic
Actions

Authored by epriestley on Feb 17 2014, 5:17 AM.

Tags

None

Referenced Files

	F15483864: D8257.id19641.diff
	Wed, Apr 9, 3:00 PM

	F15465146: D8257.id19670.diff
	Wed, Apr 2, 3:12 PM

	F15464598: D8257.id.diff
	Wed, Apr 2, 11:09 AM

	F15461116: D8257.diff
	Tue, Apr 1, 5:24 AM

	F15457165: D8257.diff
	Sun, Mar 30, 2:42 PM

	F15422821: D8257.id19670.diff
	Sat, Mar 22, 10:57 AM

	F15416482: D8257.diff
	Thu, Mar 20, 11:30 AM

	F15389536: D8257.id19670.diff
	Mar 15 2025, 5:23 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4324: Change notification server so it only alerts appropriate clients

Commits

Restricted Diffusion Commit
rPf302bfc8f811: Break Aphlict's flash policy server into a separate class

Summary

Ref T4324. One of the server we start just sends pre-canned XML responses. Separate it out of the main file and hand it all the objects it interacts with in structured, reasonable ways.

Test Plan

Hit "Send Test Notification", saw notification, saw flash policy info in the log.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 17 2014, 7:28 PM

Closed by commit rPf302bfc8f811 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

aphlict_server.js

29 lines

lib/

AphlictFlashPolicyServer.js

68 lines

Diff 19670

View Options

support/aphlict/server/aphlict_server.js