Page MenuHomePhabricator

Remove spinner GIF for loading tokenizers
ClosedPublic

Authored by epriestley on Feb 16 2014, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 10 2026, 9:48 PM
Unknown Object (File)
Mar 16 2026, 4:51 AM
Unknown Object (File)
Feb 26 2026, 12:31 PM
Unknown Object (File)
Dec 17 2025, 2:52 AM
Unknown Object (File)
Nov 29 2025, 6:18 AM
Unknown Object (File)
Nov 28 2025, 6:34 AM
Unknown Object (File)
Oct 30 2025, 11:32 AM
Unknown Object (File)
Oct 15 2025, 7:03 AM
Subscribers

Details

Summary

Ref T4420. I think the border is good enough without this spinny thing, and it needs a lot of code.

Test Plan

Used typeahead.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

We have the luxury of usually be local/intranet installs for most people. Curious how this will do on SaaS, but haven't felt we needed it on secure.

Yeah, I think we could find other display options to make it a little more prominent without needing like 50 lines of code too. We add/remove a class even without this code, and could do various things to make the effect more visible.