Page MenuHomePhabricator

Remove spinner GIF for loading tokenizers
ClosedPublic

Authored by epriestley on Feb 16 2014, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 8, 11:04 PM
Unknown Object (File)
Thu, May 8, 11:04 PM
Unknown Object (File)
Thu, May 8, 7:04 AM
Unknown Object (File)
Thu, May 8, 6:07 AM
Unknown Object (File)
Thu, May 8, 6:07 AM
Unknown Object (File)
Wed, May 7, 10:53 AM
Unknown Object (File)
Wed, May 7, 6:39 AM
Unknown Object (File)
Tue, May 6, 5:19 AM
Subscribers

Details

Summary

Ref T4420. I think the border is good enough without this spinny thing, and it needs a lot of code.

Test Plan

Used typeahead.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

We have the luxury of usually be local/intranet installs for most people. Curious how this will do on SaaS, but haven't felt we needed it on secure.

Yeah, I think we could find other display options to make it a little more prominent without needing like 50 lines of code too. We add/remove a class even without this code, and could do various things to make the effect more visible.