Page MenuHomePhabricator

Remove spinner GIF for loading tokenizers
ClosedPublic

Authored by epriestley on Feb 16 2014, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:13 PM
Unknown Object (File)
Wed, Apr 24, 2:10 AM
Unknown Object (File)
Wed, Apr 24, 2:10 AM
Unknown Object (File)
Wed, Apr 24, 2:09 AM
Unknown Object (File)
Sat, Apr 20, 6:27 PM
Unknown Object (File)
Thu, Apr 11, 4:56 AM
Unknown Object (File)
Thu, Apr 4, 6:33 AM
Unknown Object (File)
Feb 18 2024, 2:44 PM
Subscribers

Details

Summary

Ref T4420. I think the border is good enough without this spinny thing, and it needs a lot of code.

Test Plan

Used typeahead.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

We have the luxury of usually be local/intranet installs for most people. Curious how this will do on SaaS, but haven't felt we needed it on secure.

Yeah, I think we could find other display options to make it a little more prominent without needing like 50 lines of code too. We add/remove a class even without this code, and could do various things to make the effect more visible.