Page MenuHomePhabricator

Remove spinner GIF for loading tokenizers
ClosedPublic

Authored by epriestley on Feb 16 2014, 6:41 PM.
Tags
None
Referenced Files
F18788908: D8249.id19635.diff
Wed, Oct 15, 7:03 AM
F18657310: D8249.id.diff
Tue, Sep 23, 1:18 AM
F18598838: D8249.id.diff
Sep 13 2025, 5:57 AM
F18590493: D8249.diff
Sep 12 2025, 6:12 AM
F18108620: D8249.id19635.diff
Aug 11 2025, 8:06 AM
F18106979: D8249.id.diff
Aug 10 2025, 11:34 PM
F18099785: D8249.id.diff
Aug 9 2025, 8:48 AM
F18096392: D8249.diff
Aug 8 2025, 6:37 AM
Subscribers

Details

Summary

Ref T4420. I think the border is good enough without this spinny thing, and it needs a lot of code.

Test Plan

Used typeahead.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

We have the luxury of usually be local/intranet installs for most people. Curious how this will do on SaaS, but haven't felt we needed it on secure.

Yeah, I think we could find other display options to make it a little more prominent without needing like 50 lines of code too. We add/remove a class even without this code, and could do various things to make the effect more visible.