Page MenuHomePhabricator

Don't show closed typeahead results while open results exist
ClosedPublic

Authored by epriestley on Feb 14 2014, 10:26 PM.
Tags
None
Referenced Files
F13171624: D8238.diff
Tue, May 7, 11:32 AM
Unknown Object (File)
Sun, May 5, 4:12 PM
Unknown Object (File)
Wed, May 1, 6:04 PM
Unknown Object (File)
Sun, Apr 28, 12:04 AM
Unknown Object (File)
Sun, Apr 28, 12:04 AM
Unknown Object (File)
Sun, Apr 28, 12:04 AM
Unknown Object (File)
Sat, Apr 27, 11:39 PM
Unknown Object (File)
Sat, Apr 27, 11:25 AM
Subscribers

Details

Summary

Ref T4420. When a result list contains both open and closed results, hide the closed results. I think this has a good chance of almost always working, and feeling very intuitive. It has a small chance of being a weird mess. It feels reasonable to me so far

The one bad case I can come up with here is that if you have results which shadow each other, like "Apples" (a closed project) and "Apples and Bananas" (an open project), it is impossible to get "Apples" in the result list, because "Apples and Bananas" will always shadow it. Let's wait for someone to hit this before we figure out how to deal with it.

Test Plan

Typed through open stuff to hit closed stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Seems like project shortnames would provide a workaround for that case.

We can still have users @jsmith and @jsmithson, but I'm not really convinced this will ever actually happen in real life.

I would be OK for exact matches displaying both, at least when someone complains.

jsmith

  • John Smithson (jsmithson)
  • John Smith (jsmith) disabled

jsmiths

  • John Smithson (jsmithson)