Page MenuHomePhabricator

Don't show closed typeahead results while open results exist
ClosedPublic

Authored by epriestley on Feb 14 2014, 10:26 PM.
Tags
None
Referenced Files
F18791067: D8238.id19604.diff
Thu, Oct 16, 12:49 AM
F18737566: D8238.id.diff
Wed, Oct 1, 11:25 AM
F18685674: D8238.id19607.diff
Fri, Sep 26, 11:34 AM
F18627168: D8238.id19604.diff
Sep 16 2025, 3:22 AM
F18617373: D8238.id.diff
Sep 14 2025, 9:02 PM
F18599544: D8238.diff
Sep 13 2025, 7:39 AM
F18586970: D8238.diff
Sep 11 2025, 8:09 PM
F18106973: D8238.id.diff
Aug 10 2025, 11:34 PM
Subscribers

Details

Summary

Ref T4420. When a result list contains both open and closed results, hide the closed results. I think this has a good chance of almost always working, and feeling very intuitive. It has a small chance of being a weird mess. It feels reasonable to me so far

The one bad case I can come up with here is that if you have results which shadow each other, like "Apples" (a closed project) and "Apples and Bananas" (an open project), it is impossible to get "Apples" in the result list, because "Apples and Bananas" will always shadow it. Let's wait for someone to hit this before we figure out how to deal with it.

Test Plan

Typed through open stuff to hit closed stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Seems like project shortnames would provide a workaround for that case.

We can still have users @jsmith and @jsmithson, but I'm not really convinced this will ever actually happen in real life.

I would be OK for exact matches displaying both, at least when someone complains.

jsmith

  • John Smithson (jsmithson)
  • John Smith (jsmith) disabled

jsmiths

  • John Smithson (jsmithson)