Add ability to pass `width` arg to dot remarkup interpeter
ClosedPublic
Actions

Authored by dctrwatson on Feb 14 2014, 8:39 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPdbe3818d8c90: Add ability to pass `width` arg to dot remarkup interpeter

Summary

Allows to keep really wide graphs inside the div:

dot (width=100%) {{{ }}}

Test Plan

Created a graph that is wider than a phriction page.
Added (width=100%) and now the images stays within the div.

Diff Detail

Repository

rP Phabricator

Branch

dot

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/metamta/garbagecollector/MetaMTAMailReceivedGarbageCollector.php:7	PHL1	Unknown Symbol
Error	src/applications/metamta/garbagecollector/MetaMTAMailSentGarbageCollector.php:7	PHL1	Unknown Symbol
Error	src/applications/people/garbagecollector/PeopleUserLogGarbageCollector.php:7	PHL1	Unknown Symbol

Unit

Tests Passed

Event Timeline

Change to width like {F...} objects

epriestley requested changes to this revision.Feb 14 2014, 9:03 PM

epriestley added inline comments.

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php
19	This will produce `"width: "` for `dot (width=quack) {{{ ... }}}`.
52	We'll fatal here for `dot {{{ ... }}}` with no `width`, I think.

Make it work without width arg
Allow for more style options in future

Thanks!

Closed by commit rPdbe3818d8c90 (authored by @dctrwatson, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

interpreter/

PhabricatorRemarkupBlockInterpreterGraphviz.php

20 lines

Diff 19598

View Options

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php

Add ability to pass `width` arg to dot remarkup interpeterClosedPublicActions