Paths

Table of Contentst

Add ability to pass `width` arg to dot remarkup interpeter
ClosedPublic
Actions

Authored by dctrwatson on Feb 14 2014, 8:39 PM.

Tags

None

Referenced Files

	F14448325: D8235.id19598.diff
	Thu, Dec 26, 4:31 PM

	F14443218: D8235.diff
	Thu, Dec 26, 9:26 AM

	Unknown Object (File)
	Wed, Dec 11, 7:03 AM

	Unknown Object (File)
	Nov 19 2024, 11:26 PM

	Unknown Object (File)
	Nov 16 2024, 1:00 PM

	Unknown Object (File)
	Nov 12 2024, 6:07 AM

	Unknown Object (File)
	Nov 10 2024, 11:48 AM

	Unknown Object (File)
	Nov 10 2024, 9:07 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPdbe3818d8c90: Add ability to pass `width` arg to dot remarkup interpeter

Summary

Allows to keep really wide graphs inside the div:

dot (width=100%) {{{ }}}

Test Plan

Created a graph that is wider than a phriction page.
Added (width=100%) and now the images stays within the div.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Change to width like {F...} objects

epriestley requested changes to this revision.Feb 14 2014, 9:03 PM

epriestley added inline comments.

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php
19	This will produce `"width: "` for `dot (width=quack) {{{ ... }}}`.
46	We'll fatal here for `dot {{{ ... }}}` with no `width`, I think.

Make it work without width arg
Allow for more style options in future

Thanks!

Closed by commit rPdbe3818d8c90 (authored by @dctrwatson, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

interpreter/

PhabricatorRemarkupBlockInterpreterGraphviz.php

14 lines

Diff 19599

View Options

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php

Add ability to pass `width` arg to dot remarkup interpeterClosedPublicActions