Page MenuHomePhabricator
Differential D8227

Show detailed ApplicationTransaction changes in a dialog
ClosedPublic
Actions

Authored by epriestley on Feb 14 2014, 2:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 6:02 AM
Unknown Object (File)
Mon, Dec 9, 12:09 PM
Unknown Object (File)
Fri, Dec 6, 7:46 AM
Unknown Object (File)
Mon, Dec 2, 11:16 PM
Unknown Object (File)
Fri, Nov 29, 7:14 PM
Unknown Object (File)
Fri, Nov 29, 1:51 AM
Unknown Object (File)
Wed, Nov 27, 3:23 PM
Unknown Object (File)
Wed, Nov 27, 3:23 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4423: Show ApplicationTransaction details in a dialog
Commits
Restricted Diffusion Commit
rP4e8e035de006: Show detailed ApplicationTransaction changes in a dialog
Summary

Fixes T4423. This works better and is simpler and more flexible.

Test Plan

Clicked "(Show Details)", got a popup with the details.

Diff Detail

Repository
rP Phabricator
Branch
tdetails
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 14 2014, 2:39 AM
  • Remove more dead code.
chad accepted this revision.Feb 14 2014, 2:56 AM
epriestley closed this revision.Feb 14 2014, 3:37 AM

Closed by commit rP4e8e035de006 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
5 lines
storage/
2 lines
transactions/
controller/
35 lines
view/
73 lines

Diff 19575

View Options

src/applications/maniphest/controller/ManiphestTransactionPreviewController.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
Phabricator · Built by Phacility