Ref T3574. Since this list just clips in a totally reasonable way on mobile and we got another user request for it, let's bump this to 4 for now and we can refine mobile later.
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T3574: Improve project tag truncation and wrapping behavior on mobile/devices
- Commits
- Restricted Diffusion Commit
rP30ffe0ce5d99: Bump number of visible Maniphest tags to 4 (from 2)
Looked at list on desktop; saw 4 tags before truncation. Looked at list on mobile, saw reasonable clipping behavior which didn't mar usability.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- moretags
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
I'm not making an effort to do something reasonable on mobile (like 4 on desktop and 2 on mobile via CSS) since we can already clip with just 2 on mobile and these will probably get a bit bigger after T4420 / T390, when I expect to at least try adding icons to them. I think we probably need to do very slightly more work on mobile to make this always work.
| src/applications/maniphest/view/ManiphestTaskProjectsView.php | ||
|---|---|---|
| 18 | Should this be a constant elsewhere? | |
Comment Actions
This is the only place where we do this truncation right now. We probably should do it more, but a lot of stuff has only recently been getting projects. I imagine this will become ProjectTagsView or something eventually.