Updates PhabricatorTimeline to PHUITimeline. Uses standard colors and spacing, softens up the actors, and reduces visual spacing of action-only events.
- Also updated some 2x sprite images.
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T4410: Modernize Timeline View
- Commits
- Restricted Diffusion Commit
rPdb66cd830d1b: PHUITimelineView
Tested Tasks Paste and Pholio in my sandbox.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- timeline
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
Comment Actions
Part of this is I removed the 'colored' lines. So color is now specifically derived from the icon. Looks like I need to clean up the examples in UIExamples.
Comment Actions
First impressions:
- This looks really really good to me.
- Minor story text is initially a little hard to read, but I'd guess I'd get use to this in about 3 minutes of actual use. My gut reaction is that I want more contrast on the text, but I suspect this is largely because I'm looking at the element, not using the application. It's visually pleasing.
- I did like the colored lines, but let's give the colored icons a shot and see if I actually miss the lines. I'm guessing I won't. The new version looks way nicer visually.
- Blue bottom border on comments feels a tiny touch too saturated/heavy in this layout, maybe? This is not really substantive feedback. Also my monitor is probably still calibrated all crazy.
- On the larger images next to comments, the line pointing toward the picture seems to be extending halfway into it in Safari. I think this is a bug. Here's a screenshot, note how the line is extending into the image:
{F112202}