Page MenuHomePhabricator

Pholio - robustify submission errors to retain image edits
ClosedPublic

Authored by btrahan on Feb 11 2014, 7:25 PM.
Tags
None
Referenced Files
F15538621: D8197.id.diff
Thu, Apr 24, 8:27 PM
F15533194: D8197.diff
Wed, Apr 23, 6:32 PM
F15485388: D8197.diff
Wed, Apr 9, 11:24 PM
F15416562: D8197.id18549.diff
Mar 20 2025, 12:05 PM
F15389678: D8197.id18549.diff
Mar 15 2025, 5:33 AM
F15372514: D8197.id18549.diff
Mar 12 2025, 1:35 PM
Unknown Object (File)
Mar 1 2025, 2:38 PM
Unknown Object (File)
Feb 15 2025, 1:22 AM
Tokens
"Mountain of Wealth" token, awarded by chad.

Details

Summary

we should build all the image stuff on every post and use that posted image data if there's an error. this diff makes that so. Fixes T4380.

Test Plan

made a mock with no title, tried to save it, and was delighted to see my images still there. edited a mock - removing the title and adding images - verified edits showed up after erroneous submission. added a title and submitted and changes were saved.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped