Page MenuHomePhabricator

Pholio - robustify submission errors to retain image edits
ClosedPublic

Authored by btrahan on Feb 11 2014, 7:25 PM.
Tags
None
Referenced Files
F14054963: D8197.diff
Sat, Nov 16, 6:46 AM
F14042848: D8197.diff
Tue, Nov 12, 6:36 AM
F14027123: D8197.diff
Fri, Nov 8, 5:13 AM
F13990975: D8197.id18544.diff
Tue, Oct 22, 7:50 AM
F13983199: D8197.diff
Oct 20 2024, 4:43 AM
F13966697: D8197.id.diff
Oct 16 2024, 9:12 AM
Unknown Object (File)
Oct 13 2024, 3:35 AM
Unknown Object (File)
Oct 9 2024, 3:44 AM
Tokens
"Mountain of Wealth" token, awarded by chad.

Details

Summary

we should build all the image stuff on every post and use that posted image data if there's an error. this diff makes that so. Fixes T4380.

Test Plan

made a mock with no title, tried to save it, and was delighted to see my images still there. edited a mock - removing the title and adding images - verified edits showed up after erroneous submission. added a title and submitted and changes were saved.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped