Page MenuHomePhabricator

Pholio - robustify submission errors to retain image edits
ClosedPublic

Authored by btrahan on Feb 11 2014, 7:25 PM.
Tags
None
Referenced Files
F13231568: D8197.diff
Tue, May 21, 12:33 AM
F13224224: D8197.id.diff
Sun, May 19, 7:12 AM
F13188795: D8197.diff
Sat, May 11, 5:30 AM
Unknown Object (File)
Tue, May 7, 3:35 AM
Unknown Object (File)
Fri, May 3, 8:33 AM
Unknown Object (File)
Sat, Apr 27, 8:58 PM
Unknown Object (File)
Sat, Apr 27, 8:58 PM
Unknown Object (File)
Sat, Apr 27, 8:58 PM
Tokens
"Mountain of Wealth" token, awarded by chad.

Details

Summary

we should build all the image stuff on every post and use that posted image data if there's an error. this diff makes that so. Fixes T4380.

Test Plan

made a mock with no title, tried to save it, and was delighted to see my images still there. edited a mock - removing the title and adding images - verified edits showed up after erroneous submission. added a title and submitted and changes were saved.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped