Page MenuHomePhabricator

Support "only the first time" in Maniphest
ClosedPublic

Authored by epriestley on Feb 11 2014, 12:48 AM.
Tags
None
Referenced Files
F17819310: D8193.id18538.diff
Sat, Jul 26, 1:04 AM
F17817941: D8193.id18535.diff
Sat, Jul 26, 12:00 AM
F17799715: D8193.diff
Fri, Jul 25, 5:24 AM
F17796968: D8193.id18535.diff
Fri, Jul 25, 1:26 AM
F17787298: D8193.diff
Thu, Jul 24, 4:42 PM
Unknown Object (File)
Jun 17 2025, 5:50 AM
Unknown Object (File)
May 19 2025, 11:12 AM
Unknown Object (File)
May 11 2025, 3:02 AM
Subscribers
Tokens
"Love" token, awarded by dctrwatson.

Details

Summary

Ref T4403. Implements "only the first time" for Maniphest rules, and fixes the trigger itself.

The trigger would never fire and block rules because it was comparing a string (like "first") to an int (like 0).

The "only" vs "every" stuff is contributed and I should have pushed back harder on this toInt / toString stuff. Maybe I'll just get rid of it; it purely causes confusion and problems.

Test Plan

Wrote an "only the first time" rule, ran it twice, it applied once.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped