Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F20847898: D8188.diff
Thu, Jun 25, 9:27 PM
Unknown Object (File)
Tue, Jun 16, 2:35 AM
Unknown Object (File)
Apr 10 2026, 7:56 AM
Unknown Object (File)
Apr 2 2026, 2:10 PM
Unknown Object (File)
Mar 29 2026, 2:12 AM
Unknown Object (File)
Mar 14 2026, 4:16 AM
Unknown Object (File)
Mar 8 2026, 4:26 AM
Unknown Object (File)
Feb 28 2026, 6:37 PM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped