Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F19071697: D8188.id.diff
Nov 30 2025, 8:19 PM
F19069202: D8188.id18539.diff
Nov 30 2025, 1:15 PM
F19049975: D8188.diff
Nov 27 2025, 6:40 PM
F18832609: D8188.id.diff
Oct 25 2025, 10:18 PM
F18829217: D8188.diff
Oct 24 2025, 8:36 PM
F18627024: D8188.id18528.diff
Sep 16 2025, 3:00 AM
F18617740: D8188.id.diff
Sep 14 2025, 10:01 PM
F18605851: D8188.diff
Sep 13 2025, 9:28 PM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped