Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F14101249: D8188.id18539.diff
Tue, Nov 26, 3:55 PM
F14101248: D8188.id18528.diff
Tue, Nov 26, 3:54 PM
F14101247: D8188.id.diff
Tue, Nov 26, 3:54 PM
F14101246: D8188.diff
Tue, Nov 26, 3:54 PM
Unknown Object (File)
Mon, Nov 18, 5:23 PM
Unknown Object (File)
Thu, Nov 14, 5:06 AM
Unknown Object (File)
Sun, Nov 10, 9:58 AM
Unknown Object (File)
Oct 23 2024, 4:01 AM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped