Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F13994125: D8188.id.diff
Wed, Oct 23, 4:01 AM
F13983630: D8188.id.diff
Sun, Oct 20, 7:43 AM
Unknown Object (File)
Sep 25 2024, 10:38 AM
Unknown Object (File)
Sep 20 2024, 7:35 PM
Unknown Object (File)
Sep 14 2024, 7:54 PM
Unknown Object (File)
Sep 14 2024, 7:53 PM
Unknown Object (File)
Sep 14 2024, 7:53 PM
Unknown Object (File)
Sep 14 2024, 7:53 PM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped