Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F17803235: D8188.id18528.diff
Fri, Jul 25, 9:59 AM
F17798661: D8188.id.diff
Fri, Jul 25, 3:50 AM
F17795238: D8188.id18539.diff
Fri, Jul 25, 12:12 AM
F17760251: D8188.diff
Tue, Jul 22, 7:24 PM
F17706585: D8188.id18528.diff
Wed, Jul 16, 1:05 PM
F17671604: D8188.diff
Sun, Jul 13, 2:40 AM
F17636403: D8188.id18539.diff
Fri, Jul 11, 10:54 AM
F17629767: D8188.id18528.diff
Thu, Jul 10, 9:25 AM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped