Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F15165890: D8188.diff
Tue, Feb 18, 4:16 PM
Unknown Object (File)
Mon, Feb 17, 6:57 PM
Unknown Object (File)
Fri, Feb 14, 8:06 PM
Unknown Object (File)
Fri, Feb 14, 8:06 PM
Unknown Object (File)
Fri, Feb 14, 8:06 PM
Unknown Object (File)
Fri, Feb 14, 5:39 AM
Unknown Object (File)
Tue, Jan 28, 2:46 AM
Unknown Object (File)
Jan 18 2025, 12:11 AM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped