Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F19824852: D8188.diff
Sun, Mar 8, 4:26 AM
F19800837: D8188.diff
Sat, Feb 28, 6:37 PM
F19793254: D8188.id18539.diff
Thu, Feb 26, 4:43 PM
F19683000: D8188.id18539.diff
Mon, Feb 9, 12:34 AM
F19674591: D8188.id.diff
Sun, Feb 8, 7:53 AM
F19582376: D8188.diff
Feb 1 2026, 9:40 PM
F19522333: D8188.id18528.diff
Jan 17 2026, 6:26 AM
F19516985: D8188.id18528.diff
Jan 15 2026, 6:16 AM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped