Page MenuHomePhabricator

Make Projects a PhabricatorSubscribableInterface, but with restricted defaults
ClosedPublic

Authored by epriestley on Feb 7 2014, 7:28 PM.
Tags
None
Referenced Files
F14068391: D8165.diff
Tue, Nov 19, 9:36 PM
F14054006: D8165.diff
Fri, Nov 15, 9:41 PM
F14045835: D8165.id18475.diff
Wed, Nov 13, 1:08 PM
F14044114: D8165.diff
Tue, Nov 12, 3:02 PM
F14026038: D8165.diff
Thu, Nov 7, 10:33 PM
F14009317: D8165.diff
Wed, Oct 30, 2:26 PM
F13979964: D8165.diff
Oct 19 2024, 7:35 AM
F13972736: D8165.diff
Oct 17 2024, 8:55 PM
Subscribers

Details

Summary

Ref T4379. I want project subscriptions to work like this (yell if this seems whacky, since it makes subscriptions mean somethign a little different for projects than they do for other objects):

  • You can only subscribe to a project if you're a project member.
  • When you're added as a member, you're added as a subscriber.
  • When you're removed as a member, you're removed as a subscriber.
  • While you're a member, you can optionally unsubscribe.

From a UI perspective:

  • We don't show the subscriber list, since it's going to be some uninteresting subset of the member list.
  • We don't show CC transactions in history, since they're an uninteresting near-approximation of the membership transactions.
  • You only see the subscription controls if you're a member.

To do this, I've augmented PhabricatorSubscribableInterface with two new methods. It would be nice if we were on PHP 5.4+ and could just use traits for this, but we should get data about version usage before we think about this. For now, copy/paste the default implementations into every implementing class.

Then, I implemented the interface in PhabricatorProject but with alternate defaults.

Test Plan
  • Used the normal interaction on existing objects.
  • This has no actual effect on projects, verified no subscription stuff mysteriously appeared.
  • Hit the new error case by fiddling with the UI.

Diff Detail

Repository
rP Phabricator
Branch
projsub
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/ponder/storage/PonderQuestion.php:181XHP16TODO Comment
Unit
Tests Passed