turn on herald rules ability to specify other herald rules. Fixes T4294.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4294: Add a Herald rule for "new" vs "updated" for Maniphest tasks (and other updatable objects?)
- Commits
- Restricted Diffusion Commit
rPa4871d034a30: Herald - unleash some recursive madness!
made a rule to be cc'd on new tasks. made another rule to flag a task if it contained "test test" in the title AND the cc'd rule for new tasks matched. Made some new tasks and verified new "test test" tasks were flagged.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- recursiveherald
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
Comment Actions
(This doesn't give us two "Another Herald Rule" fields in Differential or anything, right?)
Comment Actions
tested differential rule and found a typo from a previous diff; fixed it.
removed FIELD_RULE from commit and differential since its now always included. Note no bug before but I think the code is more clear this way.