Page MenuHomePhabricator

Herald - unleash some recursive madness!
ClosedPublic

Authored by btrahan on Feb 6 2014, 8:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 8:16 AM
Unknown Object (File)
Sun, Dec 15, 3:29 PM
Unknown Object (File)
Thu, Dec 12, 7:24 PM
Unknown Object (File)
Mon, Dec 9, 1:47 AM
Unknown Object (File)
Sun, Dec 8, 7:56 PM
Unknown Object (File)
Wed, Dec 4, 4:26 PM
Unknown Object (File)
Sat, Nov 30, 3:12 PM
Unknown Object (File)
Nov 26 2024, 3:52 PM

Details

Summary

turn on herald rules ability to specify other herald rules. Fixes T4294.

Test Plan

made a rule to be cc'd on new tasks. made another rule to flag a task if it contained "test test" in the title AND the cc'd rule for new tasks matched. Made some new tasks and verified new "test test" tasks were flagged.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

(This doesn't give us two "Another Herald Rule" fields in Differential or anything, right?)

btrahan updated this revision to Unknown Object (????).Feb 6 2014, 8:42 PM

tested differential rule and found a typo from a previous diff; fixed it.

removed FIELD_RULE from commit and differential since its now always included. Note no bug before but I think the code is more clear this way.