Page MenuHomePhabricator

Fix accidental forward dependency in old commit summary migration
ClosedPublic

Authored by epriestley on Feb 5 2014, 10:53 PM.
Tags
None
Referenced Files
F14047453: D8152.id18441.diff
Thu, Nov 14, 4:01 AM
F14046379: D8152.diff
Wed, Nov 13, 8:35 PM
F14034224: D8152.diff
Sat, Nov 9, 10:52 PM
F14024616: D8152.id18441.diff
Thu, Nov 7, 11:07 AM
F14013808: D8152.id.diff
Sat, Nov 2, 3:19 PM
F14011429: D8152.id18441.diff
Fri, Nov 1, 12:31 AM
F14002383: D8152.id18441.diff
Fri, Oct 25, 6:31 PM
F13985672: D8152.id.diff
Sun, Oct 20, 10:16 PM
Subscribers

Details

Summary

See IRC. This migration inadvertently depends on the columns in the commit table, because it calls save(), and thus broke for installs with data after we added the importStatus column. Since that was ~9 months after this patch, probably not many installs are affected.

Test Plan

Ran patch locally with --apply on data. Had user verify fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped