Disallow "{", "}" and "#" in Project monograms
ClosedPublic
Actions

Authored by epriestley on Feb 4 2014, 2:40 AM.

Tags

None

Referenced Files

	F13086452: D8141.diff
	Thu, Apr 25, 12:19 AM

	F13082304: D8141.diff
	Wed, Apr 24, 10:05 PM

	Unknown Object (File)
	Thu, Apr 18, 10:28 PM

	Unknown Object (File)
	Thu, Apr 18, 10:28 PM

	Unknown Object (File)
	Thu, Apr 18, 9:49 PM

	Unknown Object (File)
	Wed, Apr 17, 11:26 PM

	Unknown Object (File)
	Wed, Apr 17, 9:23 PM

	Unknown Object (File)
	Thu, Apr 11, 7:39 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad
dctrwatson

Commits

Restricted Diffusion Commit
rP980f06f3da66: Disallow "{", "}" and "#" in Project monograms

Summary

Currently, mentioning two projects in a block ({#a} {#b}) produces an overzealous parse. Forbid these characters in project monograms.

Test Plan

Got correct markup.

Diff Detail

Repository

rP Phabricator

Branch

projpattern

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

chad accepted this revision.Feb 4 2014, 4:40 AM

Closed by commit rP980f06f3da66 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

phid/

PhabricatorProjectPHIDTypeProject.php

2 lines

Diff 18418

View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php

Disallow "{", "}" and "#" in Project monogramsClosedPublicActions