Page MenuHomePhabricator

Align usages of "\1" and "\2" in MercurialRepositoryAPI
ClosedPublic

Authored by richardvanvelzen on Feb 2 2014, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 9:26 AM
Unknown Object (File)
Sun, Nov 17, 12:20 AM
Unknown Object (File)
Fri, Nov 15, 5:55 PM
Unknown Object (File)
Tue, Nov 12, 4:28 AM
Unknown Object (File)
Thu, Nov 7, 11:43 PM
Unknown Object (File)
Sep 14 2024, 11:16 PM
Unknown Object (File)
Sep 14 2024, 11:15 PM
Unknown Object (File)
Sep 14 2024, 11:15 PM

Details

Summary

Especially on Windows it is hard to use "\1" type escapes in shell commands. The direct usage resulted in some undefined variables because the \1 and \2 weren't actually passed as control characters.

By passing them through the regular arguments list they get sent in the "correct way" regardless of OS

Test Plan

Executed arc diff in a HG repo and did not get undefined indexes back

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

It would be nice to be able to run these tests on windows (same for xhpast but that's a lot harder)

This really has to be tested but that should be a seperate diff.