Page MenuHomePhabricator

Partially use ApplicationSearch in main search
ClosedPublic

Authored by epriestley on Jan 31 2014, 4:57 PM.
Tags
None
Referenced Files
F13360633: D8120.diff
Tue, Jun 25, 11:42 AM
F13312115: D8120.diff
Tue, Jun 11, 6:08 AM
F13297737: D8120.diff
Fri, Jun 7, 5:54 AM
F13280778: D8120.diff
Sun, Jun 2, 9:17 AM
F13267357: D8120.diff
Wed, May 29, 3:12 AM
F13252888: D8120.diff
May 25 2024, 2:10 AM
F13231240: D8120.diff
May 21 2024, 12:18 AM
F13225169: D8120.id18403.diff
May 19 2024, 1:49 PM
Subscribers

Details

Summary

Ref T4365. Primary search currently uses PhabricatorSearchQuery for storage, which is pretty much the same as PhabricatorSavedQuery, except that it's old and not used anywhere else anymore.

Maniphest used to also use this table, but no longer does after Septmeber, 2013. We need to retain the class so the migration can work.

This introduces PhabricatorSearchApplicationSearchEngine and PhabricatorSearchDocumentQuery, but they're both stubs that I just needed for technical reasons and/or to pass lint. The next couple patches will move logic into them and use ApplicationSearch properly.

Test Plan
  • Searched for stuff.
  • Searched for stuff with filters.
  • Searched for fulltext in Maniphest.
  • Grepped for PhabricatorSearchQuery.

Diff Detail

Repository
rP Phabricator
Branch
appsearch1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/search/storage/PhabricatorSearchQuery.php:13XHP16TODO Comment
Unit
No Test Coverage