Page MenuHomePhabricator

Partially use ApplicationSearch in main search
ClosedPublic

Authored by epriestley on Jan 31 2014, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 1:40 PM
Unknown Object (File)
Nov 27 2024, 8:15 AM
Unknown Object (File)
Nov 26 2024, 11:43 AM
Unknown Object (File)
Nov 26 2024, 11:43 AM
Unknown Object (File)
Nov 26 2024, 11:43 AM
Unknown Object (File)
Nov 26 2024, 11:30 AM
Unknown Object (File)
Oct 29 2024, 9:36 PM
Unknown Object (File)
Oct 29 2024, 9:27 PM
Subscribers

Details

Summary

Ref T4365. Primary search currently uses PhabricatorSearchQuery for storage, which is pretty much the same as PhabricatorSavedQuery, except that it's old and not used anywhere else anymore.

Maniphest used to also use this table, but no longer does after Septmeber, 2013. We need to retain the class so the migration can work.

This introduces PhabricatorSearchApplicationSearchEngine and PhabricatorSearchDocumentQuery, but they're both stubs that I just needed for technical reasons and/or to pass lint. The next couple patches will move logic into them and use ApplicationSearch properly.

Test Plan
  • Searched for stuff.
  • Searched for stuff with filters.
  • Searched for fulltext in Maniphest.
  • Grepped for PhabricatorSearchQuery.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped