Page MenuHomePhabricator

Detect and prompt for passwords on SSH private keys, then strip them
ClosedPublic

Authored by epriestley on Jan 29 2014, 10:53 PM.
Tags
None
Referenced Files
F19765395: D8102.diff
Thu, Feb 19, 2:28 AM
F19525423: D8102.id18326.diff
Jan 18 2026, 8:49 AM
F19525422: D8102.id18326.diff
Jan 18 2026, 8:49 AM
F19503658: D8102.id18350.diff
Jan 9 2026, 12:59 AM
F19503657: D8102.id18326.diff
Jan 9 2026, 12:59 AM
F18934468: D8102.id.diff
Nov 10 2025, 3:06 PM
F18928556: D8102.diff
Nov 9 2025, 9:57 PM
F18830975: D8102.id18326.diff
Oct 25 2025, 9:56 AM
Subscribers

Details

Summary

Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes:

  • Prompt for the password.
  • Detect passworded private keys, and don't accept them until we can decrypt them.
  • Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect.
  • Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files.
Test Plan

Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use.

Diff Detail

Repository
rP Phabricator
Branch
passkeys
Lint
Lint Passed
Unit
No Test Coverage