Page MenuHomePhabricator

Detect and prompt for passwords on SSH private keys, then strip them
ClosedPublic

Authored by epriestley on Jan 29 2014, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 9:09 PM
Unknown Object (File)
Sun, Feb 16, 5:41 AM
Unknown Object (File)
Feb 2 2025, 3:32 AM
Unknown Object (File)
Jan 31 2025, 11:25 AM
Unknown Object (File)
Jan 28 2025, 4:11 AM
Unknown Object (File)
Jan 17 2025, 7:17 PM
Unknown Object (File)
Dec 10 2024, 7:41 PM
Unknown Object (File)
Dec 9 2024, 5:09 PM
Subscribers

Details

Summary

Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes:

  • Prompt for the password.
  • Detect passworded private keys, and don't accept them until we can decrypt them.
  • Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect.
  • Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files.
Test Plan

Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped