Page MenuHomePhabricator

Detect and prompt for passwords on SSH private keys, then strip them
ClosedPublic

Authored by epriestley on Jan 29 2014, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 17 2026, 12:11 AM
Unknown Object (File)
Apr 17 2026, 12:11 AM
Unknown Object (File)
Apr 16 2026, 7:56 AM
Unknown Object (File)
Apr 16 2026, 7:56 AM
Unknown Object (File)
Apr 6 2026, 3:54 PM
Unknown Object (File)
Apr 3 2026, 1:16 AM
Unknown Object (File)
Apr 2 2026, 12:01 AM
Unknown Object (File)
Feb 19 2026, 2:28 AM
Subscribers

Details

Summary

Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes:

  • Prompt for the password.
  • Detect passworded private keys, and don't accept them until we can decrypt them.
  • Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect.
  • Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files.
Test Plan

Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped