Page MenuHomePhabricator

Detect and prompt for passwords on SSH private keys, then strip them
ClosedPublic

Authored by epriestley on Jan 29 2014, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 18, 6:56 AM
Unknown Object (File)
Wed, Jun 18, 6:56 AM
Unknown Object (File)
Wed, Jun 18, 6:43 AM
Unknown Object (File)
Wed, Jun 18, 3:44 AM
Unknown Object (File)
May 29 2025, 6:17 PM
Unknown Object (File)
May 10 2025, 2:09 PM
Unknown Object (File)
May 8 2025, 8:15 PM
Unknown Object (File)
Mar 20 2025, 7:04 PM
Subscribers

Details

Summary

Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes:

  • Prompt for the password.
  • Detect passworded private keys, and don't accept them until we can decrypt them.
  • Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect.
  • Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files.
Test Plan

Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped