Page MenuHomePhabricator

Detect and prompt for passwords on SSH private keys, then strip them
ClosedPublic

Authored by epriestley on Jan 29 2014, 10:53 PM.
Tags
None
Referenced Files
F14027782: D8102.diff
Fri, Nov 8, 9:32 AM
F14010043: D8102.diff
Thu, Oct 31, 3:32 AM
F14005282: D8102.diff
Sun, Oct 27, 10:40 AM
F13996201: D8102.diff
Wed, Oct 23, 6:56 PM
Unknown Object (File)
Sep 5 2024, 4:34 PM
Unknown Object (File)
Sep 5 2024, 3:31 AM
Unknown Object (File)
Sep 1 2024, 1:57 PM
Unknown Object (File)
Aug 31 2024, 2:39 AM
Subscribers

Details

Summary

Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes:

  • Prompt for the password.
  • Detect passworded private keys, and don't accept them until we can decrypt them.
  • Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect.
  • Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files.
Test Plan

Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped