This seems like it would be problematic if I want the name of my repository to be different than the directory I expect it to be cloned into. The command you're generating probably doesn't work very well if there happen to be spaces in the repository name.

The command should work fine with spaces (and repositories named `sudo rm -rf /` and such), but you're right in general -- for example, this will clone Phabricator instead of phabricator. However, I think this will always clone a less surprising directory name than we did before (e.g., Phabricator is better than P).

I think we probably need to add additional configuration to set a name on disk -- we can prefill it with "lowercase and add some dashes" or something, but that won't always get things right. Then we could use that here, and provide it as the not-quite-canonical .git URI for Git.

Generally, this is an incremental step toward more reasonable behaviors, not a complete fix. I think it always produces reasonable results, and will sometimes produce the desired results.

Ok, that seems reasonable to me. Would it be possible to have a configuration option to suppress this until the "name on disk" is implemented?