Useful when there are many repos with short callsigns.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- repo-name
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
The label "Latest Stable" isn't accurate. Here, "stable" means that the name of the commit is stable: specifically, that it's a permanent identifier like 675fa765f78, instead of a mutable/unstable/dynamic identifier like HEAD or a branch name or tag name. When you're looking through history (for example, if you're looking at somefile.php a few revisions ago) it will show the commit you're looking at, not the "Latest" of anything.
As an alternative fix, maybe we should just replace rXYZ in the crumbs with the repository name? e.g.:
(Diffusion) > Phabricator > rX1234
...instead of:
(Diffusion) > rP > rX1234
Comment Actions
Ah, sorry. I'm fine with commit, I thought maybe we weren't being specific. I opted to not do it in crumbs since the callsign in that case is more precise (short), but maybe that's not so important.
(Diffusion) > Phabricator > ID seems best option?
Comment Actions
Yeah, I don't think it's too important to be specific in the crumbs (the callsign is usually all over the page anyway) and most users don't have hugely long repository names.
I think we'll probably move very gradually toward making callsigns optional (see T4245), so any steps along that path are probably OK. They're good when you have a few large repositories -- especially with SVN -- but a lot of users don't see the point.