Page MenuHomePhabricator

Add a "branches" rule for commits
ClosedPublic

Authored by epriestley on Jan 28 2014, 4:40 PM.
Tags
None
Referenced Files
F18819564: D8086.diff
Wed, Oct 22, 7:10 AM
F18753968: D8086.id18291.diff
Sat, Oct 4, 8:55 PM
F18707084: D8086.diff
Sun, Sep 28, 5:52 PM
F18651818: D8086.id.diff
Sep 21 2025, 5:36 AM
F18193423: D8086.id.diff
Aug 17 2025, 5:22 AM
F18189633: D8086.id18291.diff
Aug 16 2025, 10:07 PM
F18177817: D8086.id18294.diff
Aug 16 2025, 12:39 AM
F18165661: D8086.id18298.diff
Aug 15 2025, 8:45 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPe9be9ecfbcc9: Add a "branches" rule for commits
Summary

Fixes T1353. Also some minor unrelated cleanup:

  • openTransaction() / saveTransaction() exist now, fix TODOs.
  • Fix some instructions.
  • Make diffusion.branchquery return empty for SVN rather than fataling.
Test Plan
  • Added a branches rule.
  • Ran a dry run against commits in different VCSes.

{F105574}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 28 2014, 5:26 PM
  • Include the change which just makes SVN return empty (instead of error).