Use remote URI, not display URI, to match repositories
ClosedPublic
Actions

Authored by epriestley on Jan 28 2014, 2:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 4, 4:27 PM

	Unknown Object (File)
	Sat, Jul 4, 12:03 PM

	Unknown Object (File)
	Sat, Jul 4, 12:03 PM

	Unknown Object (File)
	Jun 28 2026, 2:28 AM

	Unknown Object (File)
	Jun 28 2026, 1:37 AM

	Unknown Object (File)
	Jun 27 2026, 8:25 PM

	Unknown Object (File)
	Jun 27 2026, 12:50 AM

	Unknown Object (File)
	Jun 26 2026, 11:35 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
talshiri

Commits

Restricted Diffusion Commit
rPf2bc293a2aea: Use remote URI, not display URI, to match repositories

Summary

I derped this up, and it passed my tests because the two URIs are the same for hosted repositories.

Match repositories against their remote URI (like https://github.com/user/repo.git), not their display URI (like /diffusion/X/).

Test Plan

i r dums

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

smooch

Closed by commit rPf2bc293a2aea (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

6 lines

Diff 18285

View Options

src/applications/repository/storage/PhabricatorRepository.php

Use remote URI, not display URI, to match repositoriesClosedPublicActions