Use remote URI, not display URI, to match repositories
ClosedPublic
Actions

Authored by epriestley on Jan 28 2014, 2:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 8, 8:11 PM

	Unknown Object (File)
	Sat, May 31, 5:39 PM

	Unknown Object (File)
	Thu, May 29, 4:57 PM

	Unknown Object (File)
	May 9 2025, 8:49 AM

	Unknown Object (File)
	May 7 2025, 5:42 AM

	Unknown Object (File)
	Apr 9 2025, 9:48 PM

	Unknown Object (File)
	Mar 15 2025, 3:21 AM

	Unknown Object (File)
	Mar 14 2025, 3:32 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
talshiri

Commits

Restricted Diffusion Commit
rPf2bc293a2aea: Use remote URI, not display URI, to match repositories

Summary

I derped this up, and it passed my tests because the two URIs are the same for hosted repositories.

Match repositories against their remote URI (like https://github.com/user/repo.git), not their display URI (like /diffusion/X/).

Test Plan

i r dums

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

smooch

Closed by commit rPf2bc293a2aea (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

6 lines

Diff 18285

View Options

src/applications/repository/storage/PhabricatorRepository.php

Use remote URI, not display URI, to match repositoriesClosedPublicActions