Page MenuHomePhabricator

Improve some messaging in `arc which` for autodetection of repositories
ClosedPublic

Authored by epriestley on Jan 28 2014, 2:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 12:25 PM
Unknown Object (File)
Tue, Dec 17, 6:20 AM
Unknown Object (File)
Sat, Dec 14, 6:47 AM
Unknown Object (File)
Dec 3 2024, 11:24 AM
Unknown Object (File)
Dec 2 2024, 9:38 AM
Unknown Object (File)
Nov 26 2024, 9:18 AM
Unknown Object (File)
Nov 22 2024, 7:41 AM
Unknown Object (File)
Nov 17 2024, 12:20 AM
Subscribers

Details

Summary
  • The modern name for the config is "project.name".
  • Missing parameter in a pht().
  • When the value is set, but not valid, we gave you a misleading error message.
Test Plan

Ran arc which.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/workflow/ArcanistBaseWorkflow.php
1661

This slightly lies though, doesn't it? getProjectID() falls back to fetching project_id

src/workflow/ArcanistBaseWorkflow.php
1661

"project_id" is a deprecated spelling of "project.name"; "project.id" (. vs _) was never correct, I just neglected to fix it after renaming project.id -> project.name mid-patch.